Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

557-refactor: Widget numbers #585

Draft
wants to merge 28 commits into
base: main
Choose a base branch
from
Draft

Conversation

Quiddlee
Copy link
Collaborator

@Quiddlee Quiddlee commented Oct 3, 2024

What type of PR is this? (select all that apply)

  • πŸ• Feature
  • πŸ› Bug Fix
  • 🚧 Breaking Change
  • πŸ§‘β€πŸ’» Code Refactor
  • πŸ“ Documentation Update

Description

Refactor Numbers widget

Related Tickets & Documents

Screenshots, Recordings

Before

Screenshot 2024-10-03 at 10 52 35β€―PM

After

Screenshot 2024-10-03 at 10 52 51β€―PM

Added/updated tests?

  • πŸ‘Œ Yes
  • πŸ™…β€β™‚οΈ No, because they aren't needed
  • πŸ™‹β€β™‚οΈ No, because I need help

[optional] Are there any post deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

CrunchCatGIF (2)

@github-actions github-actions bot changed the title 557-refactor: Widget Numbers 557-refactor: Widget numbers Oct 3, 2024
@Quiddlee Quiddlee self-assigned this Oct 3, 2024
Copy link

github-actions bot commented Oct 3, 2024

Lighthouse Report:

  • Performance: 93 / 100
  • Accessibility: 100 / 100
  • Best Practices: 100 / 100
  • SEO: 100 / 100

View detailed report

@SpaNb4
Copy link
Collaborator

SpaNb4 commented Oct 5, 2024

run visual now

@SpaNb4
Copy link
Collaborator

SpaNb4 commented Oct 10, 2024

I would ask @dzmitry-varabei and @Illia-Sakharau for their approval of the changes

All screenshots below are in before and after order:

Screenshoots

image

image

image

image

image

image

Copy link

Lighthouse Report:

  • Performance: 86 / 100
  • Accessibility: 100 / 100
  • Best Practices: 100 / 100
  • SEO: 100 / 100

View detailed report

@Illia-Sakharau
Copy link
Collaborator

Regarding #585 (comment) from @SpaNb4

In my opinion, the "before" options look better on all resolutions.
And if there is an opportunity to do it as close as possible to how it was.

Copy link

Lighthouse Report:

  • Performance: 85 / 100
  • Accessibility: 100 / 100
  • Best Practices: 100 / 100
  • SEO: 100 / 100

View detailed report

Copy link

Lighthouse Report:

  • Performance: 97 / 100
  • Accessibility: 100 / 100
  • Best Practices: 100 / 100
  • SEO: 100 / 100

View detailed report

@Quiddlee
Copy link
Collaborator Author

Update

Screenshot 2024-10-17 at 3 27 58β€―PM Screenshot 2024-10-17 at 3 29 31β€―PM Screenshot 2024-10-17 at 3 29 52β€―PM

Copy link

Lighthouse Report:

  • Performance: 68 / 100
  • Accessibility: 100 / 100
  • Best Practices: 100 / 100
  • SEO: 100 / 100

View detailed report

@SpaNb4
Copy link
Collaborator

SpaNb4 commented Oct 17, 2024

Shouldn't we apply white-space: nowrap; to the title for large screens?
image

@Quiddlee
Copy link
Collaborator Author

Shouldn't we apply white-space: nowrap; to the title for large screens? image

I don't quite get that, i have no wrapping even without white-space: nowrap;
Screenshot 2024-10-17 at 4 39 48β€―PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FSD: Widget Numbers
4 participants