Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

597-feat: Update course trainers #600

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

KristiBo
Copy link
Collaborator

@KristiBo KristiBo commented Oct 9, 2024

What type of PR is this? (select all that apply)

  • πŸ• Feature
  • πŸ› Bug Fix
  • 🚧 Breaking Change
  • πŸ§‘β€πŸ’» Code Refactor
  • πŸ“ Documentation Update

Description

Added new trainers for the following courses:

  • JS/FE Course EN
  • JS/FE Course RU
  • Angular

Related Tickets & Documents

Added/updated tests?

  • πŸ‘Œ Yes
  • πŸ™…β€β™‚οΈ No, because they aren't needed
  • πŸ™‹β€β™‚οΈ No, because I need help

Summary by CodeRabbit

  • New Features
    • Introduced new mentor entries:
      • Lyusya Cool, a moderator in the RS School Discord community, with a background in visual design.
      • Margarita Golubeva, an aspiring English teacher turned developer.
      • Denis Saripov, a Frontend Developer at Yandex Serbia.
      • Natalia Lebedeva, a Junior Software Engineer at EPAM.
  • Enhancements
    • Added biography details and photos for each new mentor.

Copy link

github-actions bot commented Oct 9, 2024

Lighthouse Report:

  • Performance: 47 / 100
  • Accessibility: 100 / 100
  • Best Practices: 100 / 100
  • SEO: 100 / 100

View detailed report

@SpaNb4 SpaNb4 marked this pull request as ready for review October 10, 2024 06:46
Copy link

coderabbitai bot commented Oct 10, 2024

πŸ“ Walkthrough

Walkthrough

This pull request introduces new mentor entries to the angular, javaScriptEn, and javaScriptRu data files. Specifically, it adds Lyusya Cool to the Angular array and includes Margarita Golubeva and Denis Saripov in the JavaScript English array. Additionally, it adds Lyusya Cool and Natalia Lebedeva to the JavaScript Russian array, along with their respective biographies and photo references.

Changes

File Path Change Summary
dev-data/angular.data.ts Added Lyusya Cool as a mentor with a biography and photo reference.
dev-data/javascript-en.data.ts Added Margarita Golubeva and Denis Saripov as mentors, including their bios and photo references.
dev-data/javascript-ru.data.ts Imported new images and added entries for Lyusya Cool and Natalia Lebedeva with their bios and photo references.

Assessment against linked issues

Objective Addressed Explanation
Add new trainers for JS/FE Course EN βœ…
Add new trainers for JS/FE Course RU βœ…
Add new trainers for Angular βœ…

Possibly related issues

Possibly related PRs

Suggested reviewers

  • dzmitry-varabei
  • andron13
  • natanchik
  • Quiddlee
  • ansivgit

πŸ“œ Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

πŸ“₯ Commits

Files that changed from the base of the PR and between f2ba874 and 6cf7f8e.

πŸ“’ Files selected for processing (3)
  • dev-data/angular.data.ts (2 hunks)
  • dev-data/javascript-en.data.ts (2 hunks)
  • dev-data/javascript-ru.data.ts (2 hunks)
🧰 Additional context used
πŸ”‡ Additional comments (9)
dev-data/javascript-en.data.ts (3)

3-3: New imports added correctly.

The new image imports for Denis Saripov and Margarita Golubeva are consistent with existing imports.

Also applies to: 5-5


20-25: New trainer entry added for Margarita Golubeva.

The entry structure is correct. Please clarify if the empty role field is intentional.


26-31: New trainer entry added for Denis Saripov.

The entry is complete and well-structured, providing relevant information about the trainer's background and expertise.

dev-data/angular.data.ts (2)

6-6: Import statement added correctly.

The new import for 'lCool' photo follows the existing pattern.


54-59: New trainer entry added successfully.

The entry for Lyusya Cool is well-structured. However, the 'role' field is empty. Is this intentional?

dev-data/javascript-ru.data.ts (4)

3-3: New imports added correctly.

The new image imports for Lyusya Cool and Natalia Lebedeva follow the existing pattern.

Also applies to: 6-6


61-66: New entry for Lyusya Cool added.

The entry follows the existing structure. Consider adding a role if applicable.


67-72: New entry for Natalia Lebedeva added.

The entry is complete with role, bio, and photo reference.


Line range hint 1-72: Changes align with PR objectives.

New trainers have been successfully added to the JavaScript Russian course data.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❀️ Share
πŸͺ§ Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@dzmitry-varabei dzmitry-varabei merged commit fa8f944 into main Oct 10, 2024
6 checks passed
@dzmitry-varabei dzmitry-varabei deleted the feat/597-update-course-trainers branch October 10, 2024 10:16
@coderabbitai coderabbitai bot mentioned this pull request Oct 15, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request preview
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update trainers on courses
5 participants