-
-
Notifications
You must be signed in to change notification settings - Fork 582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[rollup-plugin-typescript] declarationDir
inside same directory as file
option
#1773
Comments
We'd be happy to take a look at a Pull Request which resolves this condition, but one which keeps current tests passing. (Please also note that moving forward, issues without a valid reproduction will be moved to a Q & A discussion. Those aren't optional, and the issue template mentions that a bunch) |
I'm not sure i fully understand the motivation for the change that caused this; the pr didn't really go into much detail as to why this was needed. But, if i understand the code changed, it could be that reversing the order of these params making the path from ts to rollup, rather than rollup to ts, could be enough to fix the case of nested directories within the outDir and still satisfy the new unit tests.
|
Perhaps related to #1772.
Expected Behavior
Nested sub-directories continue to be valid.
Actual Behavior
Based on the breaking change, output must be the same as the declaration directory. However, I believe this check is being over-zealous, disallowing sub-directories within the declaration directory.
After the v12 update, the following error is presented:
Additional Information
The declaration directory in
tsconfig.json
:The rollup config:
If I simplify the output to
lib/config.js
, the error is gone. However, my directory structure is no longer valid.The text was updated successfully, but these errors were encountered: