support unused bindings inside typescript function type (#3060)

rome · Aug 16, 2022 · 124af3b · 124af3b
1 parent 1431af0
commit 124af3b
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 1 deletion.
diff --git a/crates/rome_js_analyze/src/semantic_analyzers/js/no_unused_variables.rs b/crates/rome_js_analyze/src/semantic_analyzers/js/no_unused_variables.rs
@@ -85,7 +85,8 @@ fn is_typescript_unused_ok(binding: &JsIdentifierBinding) -> Option<()> {
  match parameters.syntax().parent()?.kind() {
  JsSyntaxKind::TS_METHOD_SIGNATURE_CLASS_MEMBER
  | JsSyntaxKind::TS_CALL_SIGNATURE_TYPE_MEMBER
- | JsSyntaxKind::TS_METHOD_SIGNATURE_TYPE_MEMBER => Some(()),
+ | JsSyntaxKind::TS_METHOD_SIGNATURE_TYPE_MEMBER
+ | JsSyntaxKind::TS_FUNCTION_TYPE => Some(()),
  _ => None,
  }
  }

diff --git a/crates/rome_js_analyze/tests/specs/js/noUnusedVariables/noUnusedVariables.ts b/crates/rome_js_analyze/tests/specs/js/noUnusedVariables/noUnusedVariables.ts
@@ -28,3 +28,8 @@ class C {
  f(a: number);
 }
 console.log(new C());
+
+function f(fn: (title: string) => boolean) {
+ console.log(fn);
+}
+f();
diff --git a/crates/rome_js_analyze/tests/specs/js/noUnusedVariables/noUnusedVariables.ts.snap b/crates/rome_js_analyze/tests/specs/js/noUnusedVariables/noUnusedVariables.ts.snap
@@ -35,6 +35,11 @@ class C {
 }
 console.log(new C());
 
+function f(fn: (title: string) => boolean) {
+ console.log(fn);
+}
+f();
+
 ```
 
 # Diagnostics