Skip to content
This repository has been archived by the owner on Aug 31, 2023. It is now read-only.

doc: VS Code extension #3579

Merged
merged 2 commits into from
Nov 7, 2022
Merged

doc: VS Code extension #3579

merged 2 commits into from
Nov 7, 2022

Conversation

MichaReiser
Copy link
Contributor

@MichaReiser MichaReiser commented Nov 7, 2022

Summary

This PR extends the README of the VS Code extension that users see when navigating to the Rome marketplace page or opening the extension in VS Code.

Test Plan

README

@netlify
Copy link

netlify bot commented Nov 7, 2022

Deploy Preview for docs-rometools canceled.

Name Link
🔨 Latest commit 0021fb5
🔍 Latest deploy log https://app.netlify.com/sites/docs-rometools/deploys/63693f10b60d6700091dcc6d

@MichaReiser MichaReiser added this to the 10.0.0 milestone Nov 7, 2022
@MichaReiser MichaReiser marked this pull request as ready for review November 7, 2022 16:10
@MichaReiser MichaReiser requested a review from a team November 7, 2022 16:10
Copy link
Contributor

@sebmck sebmck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

editors/vscode/README.md Outdated Show resolved Hide resolved
@calibre-analytics
Copy link

Comparing doc: VS Code extension Snapshot #1 to median since last deploy of rome.tools.

LCP? CLS? TBT?
Overall
Median across all pages and test profiles
2.18s
from 192ms
0.0
no change
208ms
from 1ms
Chrome Desktop
Chrome Desktop • Cable
2.18s
from 192ms
0.0
no change
331ms
from 76ms
iPhone, 4G LTE
iPhone 12 • 4G LTE
1.01s
from 136ms
0.0
no change
7ms
no change
Motorola Moto G Power, 3G connection
Motorola Moto G Power • Regular 3G
15.4s
from 511ms
0.0
no change
208ms
from 1ms

1 page tested

 Home

Browser previews

Chrome Desktop iPhone, 4G LTE Motorola Moto G Power, 3G connection
Chrome Desktop iPhone, 4G LTE Motorola Moto G Power, 3G connection

Most significant changes

Value Budget
Total Blocking Time
Motorola Moto G Power, 3G connection
208ms
from 1ms
JS Parse & Compile
Motorola Moto G Power, 3G connection
1.71s
from 28ms
Total JavaScript Size in Bytes
Chrome Desktop
4.85 MB
from 86.8 KB
Total JavaScript Size in Bytes
iPhone, 4G LTE
4.85 MB
from 86.8 KB
Total JavaScript Size in Bytes
Motorola Moto G Power, 3G connection
4.85 MB
from 86.8 KB

28 other significant changes: JS Parse & Compile on iPhone, 4G LTE, JS Parse & Compile on Chrome Desktop, First Contentful Paint on Motorola Moto G Power, 3G connection, Largest Contentful Paint on Motorola Moto G Power, 3G connection, Speed Index on Motorola Moto G Power, 3G connection, First Contentful Paint on Chrome Desktop, Largest Contentful Paint on Chrome Desktop, Time to Interactive on Chrome Desktop, Time to Interactive on Motorola Moto G Power, 3G connection, Number of Requests on Chrome Desktop, Number of Requests on iPhone, 4G LTE, Number of Requests on Motorola Moto G Power, 3G connection, Total Page Size in Bytes on Chrome Desktop, Total Page Size in Bytes on iPhone, 4G LTE, Total Page Size in Bytes on Motorola Moto G Power, 3G connection, First Contentful Paint on iPhone, 4G LTE, Largest Contentful Paint on iPhone, 4G LTE, Total Blocking Time on Chrome Desktop, Time to Interactive on iPhone, 4G LTE, Speed Index on Chrome Desktop, Total HTML Size in Bytes on Chrome Desktop, Total HTML Size in Bytes on iPhone, 4G LTE, Total HTML Size in Bytes on Motorola Moto G Power, 3G connection, Total Image Size in Bytes on Chrome Desktop, Total Image Size in Bytes on iPhone, 4G LTE, Total Image Size in Bytes on Motorola Moto G Power, 3G connection, Lighthouse Performance Score on Motorola Moto G Power, 3G connection, Lighthouse Performance Score on Chrome Desktop

Calibre: Site dashboard | View this PR | Edit settings | View documentation

@MichaReiser MichaReiser merged commit abdb58d into main Nov 7, 2022
@MichaReiser MichaReiser deleted the doc/editor branch November 7, 2022 17:32
jeysal added a commit to jeysal/rometools that referenced this pull request Nov 8, 2022
* upstream/main:
  fix(ci): fix the release workflows for the stable release (rome#3583)
  Fix logo container margin
  Fix mobile docs regressions
  perf: End-to-end Linter and Formatter benchmarks (rome#3570)
  doc: VS Code extension (rome#3579)
  refactor(rome_cli): refactor the threading of parallel traversal to increase occupancy (rome#3577)
  [docs] Add navigation dropdown for docs (rome#3578)
  doc(rome_cli): Document `--files-max-size` option
  perf(rome_js_semantic): Use FX Hash function (rome#3565)
  fix(rome_js_analyzer): `noInvalidConstructorSuper` false positive for class expressions (rome#3561)
  Clean up mobile navigation
  doc(website): Run `cargo lintdoc` (rome#3567)
  doc: Fix install command
  Fix mobile code blocks
  Fix dark mode logo
  Update links
  Implement new website (rome#3556)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants