This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
fix(rome_js_analyze): Verify method name of React API calls #3619
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
is_react_call_api
in some situations didn't test if the method name is the tested for method name.For example,
is_react_call_api(..., "cloneElement")
returned true forReact.clone
or justclone
.I fixed the same issue in
jsx_member_name_is_react_fragment
Closes #3618
Test Plan
I added some new tests veryfing that the logic correctly verifies the member name.