Skip to content
This repository has been archived by the owner on Aug 31, 2023. It is now read-only.

🐛 Cannnot rome config push dependencies.exceptions.invalidLicenses #1177

Closed
yoshixmk opened this issue Sep 4, 2020 · 4 comments
Closed
Labels
S-To triage Status: user report of a possible bug that needs to be triaged

Comments

@yoshixmk
Copy link

yoshixmk commented Sep 4, 2020

Environment

Environment Variables
  Object {
    COLORTERM: "truecolor"
    LANG: "en_US.UTF-8"
    TERM: "xterm-256color"
    TERM_PROGRAM: "vscode"
  }

User Config
  unset

Rome Version
  10.0.4-beta

Node Version
  14.4.0

Platform
  darwin x64 19.6.0

Terminal Features
  Object {
    background: "unknown"
    colorDepth: 24
    columns: 168
    cursor: true
    hyperlinks: true
    isTTY: true
    unicode: true
  }

Client Flags
  Object {
    clientName: "cli"
    cwd: "*sorry repository here, https:/yoshixmk/f3*"
    realCwd: "*sorry repository here, https:/yoshixmk/f3*"
    silent: false
  }

Server Status
  Object {
    projects: Array [
      Object {id: 0}
      Object {id: 1}
    ]
    server: Object {
      heapTotal: 35_885_056
      pid: 67_571
      uptime: 0.688892192
    }
    workers: Array [
      Object {
        astCacheSize: 0
        heapTotal: 35_885_056
        ownedBytes: 0
        ownedFileCount: 0
        pid: 67_571
        uptime: 0.68875429
      }
    ]
  }

Steps To Reproduce

I noticed that vite uses [email protected] and removed it first.

$ yarn remove vite

then,

npx rome config push dependencies.exceptions.invalidLicenses.invalid-license-name "[email protected]"

And an error occurred during the check stage, bellow.
image
next,
I have also tried adding the config directly in rome.rjson , but it has been failure.
When I run command, I get an error

dependencies: {
	exceptions: {
		invalidLicenses: {
			"": ["[email protected]"]
		}
	}
}

Expected Results

No error occurs when add invalidLicenses settings.

@yoshixmk yoshixmk added the S-To triage Status: user report of a possible bug that needs to be triaged label Sep 4, 2020
@ematipico
Copy link
Contributor

Hi @yoshixmk , this feature is not available yet. We have a problem with the documentation where the new changes that are pushed to main are directly published to the main website. (We have an issue to track it)

This feature will be available next release

@cherihung
Copy link

cherihung commented Sep 28, 2020

is the next release with this feature the only way to bypass/address this error? I am trying to use this now but am stuck at this validation.

@ematipico
Copy link
Contributor

@cherihung yeah that's the only way.

An invalid license (of the libraries as dependencies of the project) is an error for Rome.

@ematipico
Copy link
Contributor

The feature is now enabled!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
S-To triage Status: user report of a possible bug that needs to be triaged
Projects
None yet
Development

No branches or pull requests

3 participants