Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #510 #512

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix #510 #512

wants to merge 1 commit into from

Conversation

mem48
Copy link
Collaborator

@mem48 mem48 commented Jan 12, 2023

Fix for bug identified in #510 problem occurs when input lines have repeated coordinates for some reason this is acceptable in long linestrings st_is_valid == TRUE but not short linestrings st_is_valid == FALSE

Fix for bug identified in #510 problem occurs when input lines have repeated coordinates for some reason this is acceptable in long linestrings st_is_valid == TRUE but not short linestrings st_is_valid == FALSE
Copy link
Member

@Robinlovelace Robinlovelace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Should there be a message if there are invalid geometries explaining how many linestrings and the percentage of linestrings removed? I think so. Marking as a requested change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants