[windows] Workaround for Python 2 xmlrpc performance issues. #1872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mikepurvis This is ready for review and merge. Thanks! |
dirk-thomas
reviewed
Feb 7, 2020
| set ROS_MASTER_URI=http://127.0.0.1:11311 | ||
| ) | ||
|
|
||
| if "%ROS_IP%" == "" ( |
There was a problem hiding this comment.
This doesn't take into account if ROS_HOSTNAME is set. And it is discourage to set both - ROS_IP and ROS_HOSTNAME at the same time.
There was a problem hiding this comment.
@dirk-thomas Thanks. I edited the check to make sure ROS_IP is only set when both don't exist in the environments.
|
Thanks for the patch. |
1 task
gftabor
added a commit
to gftabor/ros_comm
that referenced
this pull request
Nov 30, 2023
This PR ros#1872 made windows act differently than linux because of a specific python 2 delay doing unnecessary DNS checks for localhost. The underlying code in python is different for python3 so the hack is no longer necessary. Given that, its better to reunify the codebase
sloretz
pushed a commit
that referenced
this pull request
Sep 4, 2024
This PR #1872 made windows act differently than linux because of a specific python 2 delay doing unnecessary DNS checks for localhost. The underlying code in python is different for python3 so the hack is no longer necessary. Given that, its better to reunify the codebase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a ROS performance slowness issue that we root caused to an existing issue for Python 2. One discussion can be found here: https://stackoverflow.com/questions/2617615/slow-python-http-server-on-localhost
Instead of asking Windows developers to manually override the
ROS_MASTER_URIandROS_IPto workaround it, I am proposing that, by default, make them to be IP address directly.This fixes ms-iot/ROSOnWindows#6.