Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

panda_moveit_config: 0.7.7-1 in 'melodic/distribution.yaml' [bloom] #34297

Closed
wants to merge 1 commit into from

Conversation

rhaschke
Copy link
Contributor

@rhaschke rhaschke commented Sep 1, 2022

Increasing version of package(s) in repository panda_moveit_config to 0.7.7-1:

panda_moveit_config

* Thorough rework based on franka_description 0.9.1 (using fine and coarse collision models)
  The internal robot controller uses coarse collision models for self-collision checking.
  In MoveIt, these coarse models should be used for self-collision checking only as well.
  Particularly, these coarse models should not be used for collision checking with the environment.
* Adapt ACM configuration to Melodic
  Melodic's srdfdom/MoveIt don't support tags <disable_default_collisions> and <enable_collisions>.
* Remove adapter ResolveConstraintFrames
  as it's not implemented in Melodic

@github-actions github-actions bot added the melodic Issue/PR is for the ROS 1 Melodic distribution label Sep 1, 2022
@ahcorde ahcorde added the held for sync Issue/PR has been held because the distribution is in a sync hold label Sep 1, 2022
@ahcorde
Copy link
Contributor

ahcorde commented Sep 1, 2022

Holding for sync

@rhaschke
Copy link
Contributor Author

rhaschke commented Sep 1, 2022

Unfortunately, the recently merged release 0.9.1 of franka_description and this one of panda_moveit_config are strongly related. Thus, holding this back is unfortunate.
In case you have to rework the current sync anyway (because of #34283 (comment)), it would be great if you could still consider this update. If not, a follow-up release sync including this package would be great.
Otherwise, panda_moveit_config would be broken until the next sync.
Thanks a lot.

@ros-discourse
Copy link

This pull request has been mentioned on ROS Discourse. There might be relevant details there:

https://discourse.ros.org/t/preparing-for-melodic-sync-2022-09-01/27180/2

@rhaschke
Copy link
Contributor Author

rhaschke commented Sep 2, 2022

Closing for now as the franka_ros 0.9.1 (a prerequisite) was reverted.

@rhaschke rhaschke closed this Sep 2, 2022
@rhaschke rhaschke deleted the bloom-panda_moveit_config-1 branch September 20, 2022 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
held for sync Issue/PR has been held because the distribution is in a sync hold melodic Issue/PR is for the ROS 1 Melodic distribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants