Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cppzmq-dev to the libzmq3-dev key #41413

Merged
merged 1 commit into from
May 31, 2024
Merged

Conversation

azeey
Copy link
Contributor

@azeey azeey commented May 30, 2024

Starting in Debian Bookworm and Ubuntu Noble, the cppzmq headers have been extracted out of libzmq3-dev and placed in their own package, cppzmq-dev. This updates the libzmq3-dev key to include cppzmq-dev for Debian and Ubuntu to maintain parity with the other platforms.

Starting in Debian Bookworm and Ubuntu Noble, the cppzmq headers have
been extracted out of `libzmq3-dev` and placed in their own package,
`cppzmq-dev`. This updates the `libzmq3-dev` key to include `cppzmq-dev`
for Debian and Ubuntu to maintain parity with the other platforms.

Signed-off-by: Addisu Z. Taddese <[email protected]>
@azeey azeey requested a review from a team as a code owner May 30, 2024 15:11
@github-actions github-actions bot added the rosdep Issue/PR is for a rosdep key label May 30, 2024
@nuclearsandwich
Copy link
Member

I'd like some feedback on this from other folks with rosdep opinions.
@cottsay should we take this opportunity to follow the upstream lead and keep these dependencies distinct or maintain compatibility with rosdep keys from earlier platforms?

I'm slightly in favor of adding a new key and requiring packages to update their dependencies to match as appropriate. But if this is just Debian style-churn rather than a change that will eventually propagate out to other packagers perhaps it isn't worth it.

Copy link
Member

@nuclearsandwich nuclearsandwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We had an in-depth discussion about this and the "convenient moment" to fix this prompted by the new debian and ubuntu distributions doesn't apply to the other packages that we would retro-actively need to change and therefore would break in active distributions.

We could add dedicated keys for cppzmq-dev so that this can be separated in the future but it's not a requirement to merge this as is.

@nuclearsandwich
Copy link
Member

Although there is no direct evidence, @cottsay did assent to merging this as-is. He can disavow this if I am mistaken but I'm treating this as having received the necessary reviews.

@nuclearsandwich nuclearsandwich merged commit 5761fbe into ros:master May 31, 2024
4 checks passed
@azeey azeey deleted the add_cppzmq branch May 31, 2024 18:33
@ruffsl
Copy link
Contributor

ruffsl commented Jul 12, 2024

Oh boy, this bit me earlier this week while migrating to Jazzy using only rosdep to install vendored gazebo dependencies. Was really puzzled with libzmq3-dev already installed, but turns out I should've just update my rosdep list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rosdep Issue/PR is for a rosdep key
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants