-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ros2_batch_job --workspace-path option does not work #600
Comments
The purpose of That said, I'm guessing that this option is rarely, if ever, used. I'd be OK with removing the option altogether; while we should test whitespaces-in-path somehow, this doesn't seem like the right way to do it. Thoughts from anyone else? |
Looking at the code we see that the argparse option declared here:
ci/ros2_batch_job/__main__.py
Lines 238 to 240 in eb8d0ad
is not actually used anywhere in the code. So setting this option has no affect on the job.
I'm not sure exactly how to fix the argument because I don't understand the purpose of the
--white-space-in
option, which is coupled to determining the actual workspace named used:ci/ros2_batch_job/__main__.py
Line 427 in eb8d0ad
If I'm not mistaken, this section of code is relevant as well:
ci/ros2_batch_job/__main__.py
Lines 267 to 270 in eb8d0ad
Here are other references to the option I could find:
ci/job_templates/ci_job.xml.em
Line 123 in eb8d0ad
ci/job_templates/ci_job.xml.em
Line 265 in eb8d0ad
ci/job_templates/ci_job.xml.em
Line 368 in eb8d0ad
The text was updated successfully, but these errors were encountered: