Put quotes around curled url and filename #666
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Audrow Nash <[email protected]>
Signed-off-by: Audrow Nash <[email protected]> Co-authored-by: Steven! Ragnarök <[email protected]>
Signed-off-by: Audrow Nash <[email protected]>
audrow
force-pushed
the
audrow/add-quotes-to-curl
branch
from
bb50fe3
to
06ce190
Compare
|
Linux seems to be working (https://ci.ros2.org/job/ci_linux/16766/), but I'm getting Windows failures; eg, https://ci.ros2.org/job/ci_windows/17164/console#console-section-1. I'll look into this later. Do let me know if anyone has suggestions of how to resolve these. |
audrow
force-pushed
the
audrow/add-quotes-to-curl
branch
2 times, most recently
from
11e0e70
to
06ce190
Compare
|
I'm not exactly sure how to get past Windows. I'm going to close this for now. I may try again in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows a
ros2.reposurl to have special characters. This is useful for a tool that I'm working on https:/audrow/next-repos-ci, which creates a repo file from the url.Before this PR, this CI failed.