Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate constants from c++ image headers into the sensor_msgs/Image as enums or consts or consts #99

Open
tfoote opened this issue Apr 7, 2020 · 1 comment
Open

Migrate constants from c++ image headers into the sensor_msgs/Image as enums or consts or consts #99

tfoote opened this issue Apr 7, 2020 · 1 comment

Comments

@tfoote
Copy link
Contributor

tfoote commented Apr 7, 2020

This is a follwup to the pre Foxy Message API review

common_interfaces/sensor_msgs/msg/Image.msg

Line 21 in 519e851

string encoding # Encoding of pixels -- channel meaning, ordering, size

From:

common_interfaces/sensor_msgs/include/sensor_msgs/image_encodings.hpp

Line 47 in 519e851

const char RGB8[] = "rgb8";

@tfoote tfoote changed the title Migrate constants from c++ image headers into the Image header Migrate constants from c++ image headers into the sensor_msgs/Image as enums Apr 7, 2020
@tfoote tfoote changed the title Migrate constants from c++ image headers into the sensor_msgs/Image as enums Migrate constants from c++ image headers into the sensor_msgs/Image as enums or consts or consts Apr 7, 2020
@tfoote
Copy link
Contributor Author

tfoote commented Apr 8, 2020

Also make sure that we're not missing common ones that are now in OpenCV and other places.

https:/ros2/common_interfaces/pull/86/files#r392504087

@tfoote tfoote mentioned this issue May 18, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tfoote