call shutdown in LifecycleNode dtor to avoid leaving the device in unknown state (2nd) (backport #2528) #2542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
…known state (2nd) (#2528) * Revert "Revert "call shutdown in LifecycleNode dtor to avoid leaving the device in un… (#2450)" (#2522)" This reverts commit 42b0b57. Signed-off-by: Tomoya Fujita <[email protected]> * lifecycle node dtor shutdown should be called only in primary state. Signed-off-by: Tomoya Fujita <[email protected]> * adjust warning message if the node is still in transition state in dtor. Signed-off-by: Tomoya Fujita <[email protected]> --------- Signed-off-by: Tomoya Fujita <[email protected]> (cherry picked from commit 3bc364a)
fujitatomoya
approved these changes
May 29, 2024
|
CI:
|
|
The reason for the Linux-aarch64 failure is identical to issue #2528 (#2528 (comment)) |
|
please do not merge this yet, i think we need to add #2545. |
This was referenced May 30, 2024
Signed-off-by: Tomoya Fujita <[email protected]>
|
CI:
|
|
CI:
|
|
i think this is know issue of ros2/Mimick#36, mimick: Initialization error: could not find definitions for vital function(s): 'abort' 'vfprintf'
-- run_test.py: return code -6 |
|
https://ci.ros2.org/job/ci_linux-aarch64/15552/#showFailuresLink is exactly same with https://ci.ros2.org/job/ci_linux-aarch64/15479/#showFailuresLink, known issue for jazzy CI. |
fujitatomoya
added a commit
that referenced
this pull request
Jun 10, 2024
…ce in unknown state (2nd) (backport #2528) (#2542)" This reverts commit 8ab10aa. Signed-off-by: Tomoya Fujita <[email protected]>
fujitatomoya
added a commit
that referenced
this pull request
Jun 11, 2024
…ce in unknown state (2nd) (backport #2528) (#2542)" (#2558) This reverts commit 8ab10aa. Signed-off-by: Tomoya Fujita <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
address #2520
depends on #2527
This is an automatic backport of pull request #2528 done by Mergify.