Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transform css module imports during build #120

Closed
wants to merge 1 commit into from
Closed

Transform css module imports during build #120

wants to merge 1 commit into from

Conversation

danny-andrews
Copy link
Collaborator

@danny-andrews danny-andrews commented Jun 7, 2017

This changeset transforms css module imports as part of the build process.

Fixes #80 and #28 and possibly #84.

@danny-andrews
Copy link
Collaborator Author

danny-andrews commented Jun 7, 2017

This is a breaking change and will require consumers to include lib/index.css in their stylesheet bundle.

@gabemeola
Copy link

Awesome, this is exactly what I've been waiting for.

@danny-andrews
Copy link
Collaborator Author

@roylee0704 Any thoughts on this?

@lfender6445
Copy link

@danny-andrews it looks as though the CI build is failing due to a lint error

@danny-andrews
Copy link
Collaborator Author

Closing in favor of #126. I accidentally killed the fork this PR was based off of so I had to rebuild it. :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants