[script] [combat-trainer] Added necro_corpse_priority: setting #6893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added `necro_corpse_priority:` setting to allow for prioritization of using corpses for either healing or pet creation. Default behavior is to prioritze healing from corpses. Exclude it, leave it blank or set it to `heal`. To have it prioritize pet creation from corpses set it to `pet`. Rituals other than consue/arise have not changed. They are handled separately in the rituals section and continue to be prioritized behind pets and healing as before.
|
Hold up on merging. Not quite working yet, missed a detail |
Refactored original attempt to work correctly. Okay to merge now.
|
Refactored to work correctl.y. Okay to merge now. |
|
How well tested is this? Can you get a couple of volunteers on discord to test? |
|
I've been running a couple months this since I submitted it without issue, but I don't think anyone else has tried it out. I've mostly been running it with the new setting set to 'pet', with a bit of testing it set to 'heal' or having it blank or non-existant. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
necro_corpse_priority:setting to allow for prioritization of using corpses for either healing or pet creation. This does not change any behavior unless the setting is added to a yaml.Default behavior is to prioritze healing from corpses over pet creation, and this is the same behavior as before this update. To have it do this, exclude the setting, leave it blank or set it to
heal. To have it prioritize pet creation from corpses set it topet.Rituals other than consume/arise also have not changed. They are handled separately in the rituals section and continue to be prioritized behind both pets and healing as before.