PlanMigration returns error when no safe migration is possible #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As discussed in GitHub issue rubenv#43 the PlanMigration function would not allow running migrations when the there are already applied migrations in the database which are not part of the migration source. In such cases the user have to decide what to do. This also fixes a bug where running the `up` migration would result in success exit status while nothing has been done.
This removes the need to create and remove files in the filesystem during testing. Less moving parts is always better I would think.
|
Bit late to come back to this, but looks very good to me, thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #43 and #85 there are problems when the database contains migrations which are not part of the current plan. Up to this PR
sql-migratewas just ignoring such cases and hoped for the best.The PR adds a new error type
PlanErrorand uses it when a mismatch between the database migrations and the current source migrations is found. This way one would be able to ignore this error while usingsql-migrateas a library if need be.