AssertKindOf
: also replace is_a?
as well
#298
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Minitest/AssertKindOf
would replace this code:... but not:
...even though they are practically the same, since
#is_a?
is an alias for#kind_of?
(not to be confused with#instance_of?
).This PR simply extends
Minitest/AssertKindOf
to correct both.I opted to modify the existing cop, rather than introducing a new cop like
Minitest/AssertIsA
, because it seems really unlikely to me that somebody would like to correct one, but not the other. Perhaps that's just a lack of imagination, let me know if there are any objections.Before submitting the PR make sure the following are checked:
Commit message starts with[Fix #issue-number]
(if the related issue exists).master
(if not - rebase it).bundle exec rake default
. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.md
if the new code introduces user-observable changes. See changelog entry format for details.