Handle Enumerable values on Repository#delete
#63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A test for `RDF::Enumerable` inputs was added by ruby-rdf/rdf-spec#39. This adds conformance, and allows `SPARQL::Client::Repository` to use the new `Mutable#delete_insert` interface. It does not yet implement an effecient SPARQL `#delete_insert`. It may be possible to refactor `#delete_statements` in response to these changes, to remove the code smells called out in the comment in that method.
gkellogg
added a commit
that referenced
this pull request
Nov 7, 2015
Handle `Enumerable` values on `Repository#delete`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A test for
RDF::Enumerableinputs was added by ruby-rdf/rdf-spec#39. This adds conformance, and allowsSPARQL::Client::Repositoryto use the newMutable#delete_insertinterface. It does not yet implement an efficient SPARQL#delete_insert.It may be possible to refactor
#delete_statementsin response to these changes, to remove the code smells called out in the comment in that method.