Make readpartial limit chunk to appropriate size #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for trying to fix this, I will give your change a try with JRuby. |
|
Well if this is any indication the change seems good: JRuby is now down to only one failure on the WEBrick tests, provided that the locale-sensitive CGI test skipped on Windows is also skipped on JRuby (the JVM does not make it possible to get raw bytes from env vars, as is needed in that test). |
This was referenced Jun 1, 2020
|
It makes sense to have readpartial not return more bytes than requested, so I'm going to merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #43 by unshifting portion of chunk that exceeds requested length.