Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tgt cookie lifetime should > maximum_session_lifetime #178

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

tgt cookie lifetime should > maximum_session_lifetime #178

wants to merge 1 commit into from

Conversation

anvyzhang
Copy link

If maximum_session_lifetime was set, then tgt cookie should have a life time more than maximum_session_lifetime

@mitfik
Copy link
Contributor

mitfik commented Aug 11, 2013

Hi,

As I understand we do not set any expiration time which mean that by default it should be "At end of session".
So I do not see any reason why we would like to set any. Could you provide your scenario where you need that? Or explain why you want to add that.

Thanks

@ghost ghost assigned mitfik Aug 11, 2013
@anvyzhang
Copy link
Author

rubycas-server/lib/casserver/cas.rb:152

if settings.config[:maximum_session_lifetime] && Time.now - tgt.created_on > settings.config[:maximum_session_lifetime]

tgt stores in cookie if maximum_session_lifetime was set and cookie tgt lifetime shorter than maximum_session_lifetime then error No ticket granting ticket given. occurred. but it was not supposed to be like this since you set maximum_session_lifetime

@anvyzhang
Copy link
Author

then what?

@mitfik
Copy link
Contributor

mitfik commented Sep 4, 2013

then we will create few tests to confirm your error/scenario and then we will apply the fix. We need to make sure that it will not break anything. I will try to do it as soon as possible I will keep posting you about progress.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants