Remove unused local variable and move local variables into conditional branch #546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delete dead code that became unused due to changes in commit 9937512
…ignment to association_foreign_key
…class.paranoid? is true, inside the conditional branch
mathieujobin
reviewed
Sep 1, 2023
mathieujobin
reviewed
Sep 1, 2023
ken3ypa
deleted the
remove-unused-variable-and-move-variable-in-condition
branch
karunkumar1ly
pushed a commit
to edcast/paranoia
that referenced
this pull request
Feb 6, 2024
* Remove unused local variable delete dead code that became unused due to changes in commit 9937512 * group the assignment to the local variable in the same way as the assignment to association_foreign_key * move temporary variables, which are only referenced when association_class.paranoid? is true, inside the conditional branch * simplify association_find_conditions further --------- Co-authored-by: Mathieu Jobin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found dead code, minor enhancement point and fixed them：
association_class_nameintroduced in commit 9937512 .association_class.paranoid?is true.association_foreign_key.