text: Fix layout measurements #18332
Open
+1,068
−61
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes various measurements made during laying out text.
After laying out a line, the cursor should be advanced by the value of
ascent + descent + leading
, notfont_size + font_leading + leading
.Font leading is ignored.
Proper line bounds (not interior bounds) are now used for calculating exterior text bounds.
Additionally, it updates the following tests, as their output now is more similar to the output produced by the Flash Player:
avm2/away3d_advanced_shallow_water_demo
visual/definefont4
visual/fonts/device-font
visual/shumway_acid_tests/acid
visual/shumway_acid_tests/acid_text
In general, this PR should make a lot of text look so much better, especially multiline text fields.