Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG]: Missing validate basic checks #302

Open
1 task done
joneskm opened this issue Oct 1, 2024 · 0 comments
Open
1 task done

[BUG]: Missing validate basic checks #302

joneskm opened this issue Oct 1, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@joneskm
Copy link
Member

joneskm commented Oct 1, 2024

Is there an existing issue for this?

  • I have searched the existing issues

What happened?

Some transaction structs are missing validate_basic checks e.g.

gears/x/staking/src/types/tx.rs

Line 376 in 694064e

// see https:/cosmos/cosmos-sdk/blob/2582f0aab7b2cbf66ade066fe570a4622cf0b098/x/staking/types/msg.go#L89-L144

We need to check all our tx types.

Gears version

main

Steps to reproduce?

No response
@joneskm joneskm added the bug Something isn't working label Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@joneskm