Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing AutoMerge issue with Azure DevOps #1289

Merged
merged 14 commits into from
Jan 13, 2021
Merged

Fixing AutoMerge issue with Azure DevOps #1289

merged 14 commits into from
Jan 13, 2021

Conversation

tapaszto
Copy link
Contributor

@tapaszto tapaszto commented Dec 4, 2020

This PR is fixing the #1152 Azure DevOps related issue by getting the Azure DevOps user Id on the fly and putting it into azuredevops.GitPullRequest.AutoCompleteSetBy.

@codecov
Copy link

codecov bot commented Dec 8, 2020

Codecov Report

Merging #1289 (709defa) into master (9e92a36) will decrease coverage by 0.04%.
The diff coverage is 54.54%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1289      +/-   ##
==========================================
- Coverage   70.05%   70.00%   -0.05%     
==========================================
  Files          74       74              
  Lines        5540     5545       +5     
==========================================
+ Hits         3881     3882       +1     
- Misses       1303     1305       +2     
- Partials      356      358       +2     
Impacted Files Coverage Δ
server/server.go 62.40% <0.00%> (ø)
server/events/vcs/azuredevops_client.go 65.67% <60.00%> (-1.17%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e92a36...709defa. Read the comment docs.

@tapaszto
Copy link
Contributor Author

tapaszto commented Dec 8, 2020

Hi @lkysow

Can You advise please why the ci/circleci: test is pending? Do we need to do any further steps in order to get our PR merged?

@Dilergore
Copy link

Hi @lkysow ,

Could you please take a look? We would like to continue with other enhancements for Azure DevOps which for this is a prerequisite.

Thanks!

@acastle
Copy link
Contributor

acastle commented Dec 14, 2020

Hi @tapaszto, it seems your branch has drifted behind master a bit. If you could either merge or rebase to resolve the conflicts I will be happy to get this merged in.

@tapaszto
Copy link
Contributor Author

Hi @acastle,

I performed a merge and resolved the conflicts, can You approve the PR please?

Copy link
Contributor

@acastle acastle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@tapaszto
Copy link
Contributor Author

Hi @acastle ,

Thanks for approving the PR, but I'm not sure what to do now, can You advise please? Will it be automatically merged or do I need to perform any further steps?

@acastle
Copy link
Contributor

acastle commented Dec 22, 2020

Hi @tapaszto, our typical process is to get two sets of eyes from the maintainer group on non trivial PRs before they are merged. Once another maintainer gives an ok we will get this merged and released.

There is nothing further you need to do at this point. I can't comment on when exactly you can expect these changes to be in a release but it will likely be after the holidays as a number of the maintainers are enjoying some well deserved time off 😀

@tapaszto
Copy link
Contributor Author

tapaszto commented Jan 7, 2021

Hi @lkysow & @acastle,

Can you advise who can be the second approver in order to get our PR merged?

Copy link
Member

@lkysow lkysow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@acastle acastle merged commit 68e20b1 into runatlantis:master Jan 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants