Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert removal of --all-namespaces from policy checks #1542

Closed
wants to merge 1 commit into from
Closed

Revert removal of --all-namespaces from policy checks #1542

wants to merge 1 commit into from

Conversation

rgooler
Copy link

@rgooler rgooler commented Apr 29, 2021

#1516 included an undocumented change, removing the --all-namespaces argument from conftest runs.

This is a particularly painful change for myself and others, as it breaks the ability to use namespacing to manage and organize policy collections. Its a significant behavior regression from the beta as well - with no explanation as to why this was desired, or should have been a part of a version bump for conftest.

This PR reverts the parts of #1516 that removed --all-namespaces, and restores the original behavior.

@rgooler rgooler requested a review from a team as a code owner April 29, 2021 23:41
@nishkrishnan
Copy link
Contributor

I just want to close the thread out on this:
#1516 (comment)

Given that this got changed as a part of an upgrade from a pre-release to a production release. I'd rather just extend the policy checking step to support extra args through the server side repo config.

Can get this done and released as part of a minor version bump soon, but the workaround suggested in the the linked issue is good enough to get this working.

@nishkrishnan
Copy link
Contributor

Btw here's the PR: #1543

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants