Redact clone url during clone errors. #618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If there was an error during cloning, we would sometimes print the clone credentials to the pull request and in the Atlantis logs. This change ensures we print the redacted clone url. We also change the redacted clone url to contain "username:<redacted>" so that if users see the redacted url in logs, they'll know we were using a credentialed form and so if they try to replicate with curl they'll know to substitute the correct credentials.
Codecov Report
@@ Coverage Diff @@
## master #618 +/- ##
==========================================
+ Coverage 72.15% 72.17% +0.02%
==========================================
Files 61 61
Lines 4629 4633 +4
==========================================
+ Hits 3340 3344 +4
Misses 1044 1044
Partials 245 245
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there was an error during cloning, we would sometimes print the clone
credentials to the pull request and in the Atlantis logs. This change
ensures we print the redacted clone url.
We also change the redacted clone url to contain "username:"
so that if users see the redacted url in logs, they'll know we were
using a credentialed form and so if they try to replicate with curl
they'll know to substitute the correct credentials.
Fixes #615