Configure git to use https instead of ssh.

[andrewjeffree]

Pretty straightforward. Means that when write-git-creds is used it'll work for ssh and https sources without any changes needed. This was discussed in #711

[codecov]

Codecov Report

Merging #799 into master will decrease coverage by 0.01%.
The diff coverage is 50%.

@@            Coverage Diff             @@
##           master     #799      +/-   ##
==========================================
- Coverage   72.77%   72.75%   -0.02%     
==========================================
  Files          63       63              
  Lines        4812     4816       +4     
==========================================
+ Hits         3502     3504       +2     
- Misses       1051     1052       +1     
- Partials      259      260       +1

Impacted Files	Coverage Δ
cmd/server.go	79.42% <ø> (ø)	⬆️
server/events/git_cred_writer.go	83.33% <50%> (-6.67%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ecda302...a9c843d. Read the comment docs.

[lkysow]

🎉

[lkysow]

Oops, one thing I realized we missed. We should update the docs for the flag:

      Write out a .git-credentials file with the provider user and token to allow
      authentication with git over HTTPS. This does write secrets to disk and should
      only be enabled in a secure environment.

to

      Write out a .git-credentials file with the provider user and token to allow
      cloning private modules over HTTPS or SSH. This does write secrets to disk and should
      only be enabled in a secure environment.

[andrewjeffree]

Ah yep. I've just updated the documentation. So should be all good to go now.

[andrewjeffree]

@lkysow it won't let me mark your requested changes as fixed/completed for some reason.

[lkysow]

@ImperialXT weird. Can you also update
https:/runatlantis/atlantis/blob/master/cmd/server.go#L231-L233

[andrewjeffree]

@lkysow done :)

[lkysow]

🎉 awesome work! I'll try to get a release out soon. :D

[Jenishk56]

Hello there,

Big confused, Do i need to add .git-credentials file when use write-git-creds ?