Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E-951: new command scp-help: teaches people how to use scp #151

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

ef0xa
Copy link
Contributor

@ef0xa ef0xa commented Jun 24, 2024

E-951 - teach people how to use SCP

Add new command, scp-help, which teaches users how to use SCP. Since it will show up in the command list, that should make this behavior more discoverable.

I also slightly cleaned up send and receive so that they don't fail with index-out-of-range errors and added an (extremely generous) timeout for for looking up the relays so it doesn't just hang forever.

How I tested it

Nothing to test.

Short: "send file(s), or folder",
Long: "send file(s), or folder to pod or any computer",
Run: func(cmd *cobra.Command, args []string) {

rand.Seed(time.Now().UnixNano())
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no longer necessary (and in fact reduces the randomness rather than enhancing it in go >= 1.22 : https://go.dev/blog/chacha8rand

@ef0xa ef0xa requested a review from DireLines June 26, 2024 22:52
@ef0xa ef0xa changed the title E-951: new command - scp-help - teaches people how to use scp E-951: new command scp-help: teaches people how to use scp Jun 26, 2024
@DireLines DireLines merged commit 00683ce into main Jul 1, 2024
1 check passed
@DireLines DireLines deleted the E-951-scp branch July 1, 2024 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants