Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

io: add error kinds from std. #471

Merged
merged 1 commit into from
Jul 12, 2023
Merged

io: add error kinds from std. #471

merged 1 commit into from
Jul 12, 2023

Conversation

Dirbaio
Copy link
Member

@Dirbaio Dirbaio commented Jul 12, 2023 •
edited
Loading

depends on #466

This copies all stable variants from std::io::ErrorKind, except:

  • WouldBlock is removed, since embedded-io traits are always blocking. See the crate-level documentation for details.
  • WriteZero is removed, since it is a separate variant in [WriteAllError] and [WriteFmtError].

@Dirbaio Dirbaio requested a review from a team as a code owner July 12, 2023 13:58
eldruin
eldruin approved these changes Jul 12, 2023
View reviewed changes
Copy link
Member

@eldruin eldruin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me, thanks!

@eldruin eldruin added this pull request to the merge queue Jul 12, 2023
Merged via the queue into master with commit c5c5507 Jul 12, 2023
22 checks passed
@Dirbaio Dirbaio mentioned this pull request Jul 12, 2023
Closed
@Dirbaio Dirbaio mentioned this pull request Aug 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eldruin eldruin eldruin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Dirbaio @eldruin