Fix cross-compile same-triple problem using unstable flags even for stable channel #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The env vars LD and TARGET_LD are exported, but incorrectly refer to a script that doesn't exist (probably a typo). Fix the typo to refer to the proper scripts. Fixes rust-embedded#128
This fixes cross-compiles with same-triple where target linker and tools would be used for build-scripts that run on host
|
I assume this will cause errors on the older versions of cargo supported by this layer? I wonder what the opinion is on supporting older versions (I'm not a maintainer here), either way those recipes should be removed in this PR, or this should be hidden behind a switch based on the cargo version? |
Well this should at least work with |
|
Should be addressed by #146 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this fix, rust/cargo assumes that if host-triple matches target-triple, that the target linker (and tools) can be used to for the build-scripts which run during build.
This PR has @rich-g's fix #128
as well as the fix described here on guidance from @jameshilliard here rust-lang/cc-rs#82 (comment)
I see that @banditopazzo has a similar fix as a #133