Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

N36: Add bevy_fbx section #1115

Merged
merged 4 commits into from
Aug 8, 2022
Merged

N36: Add bevy_fbx section #1115

merged 4 commits into from
Aug 8, 2022

Conversation

nicopap
Copy link
Contributor

@nicopap nicopap commented Aug 2, 2022

Part of #1098

Note that the model is reproduced with the author's full consent.

@nicopap nicopap changed the title Add bevy_fbx section to N36 N36: Add bevy_fbx section Aug 2, 2022
ozkriff
ozkriff approved these changes Aug 8, 2022
View reviewed changes
Copy link
Member

@ozkriff ozkriff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 (i've collapsed the second list to fit into the "Avoid having multiple/nested bullet points" style rule, hope it's ok)

@ozkriff ozkriff merged commit d2e3353 into rust-gamedev:source Aug 8, 2022
@ozkriff
Copy link
Member

ozkriff commented Aug 8, 2022

Thanks for the PR!

@nicopap
Copy link
Contributor Author

nicopap commented Aug 8, 2022

There was a last minute change. Our crate's name changed from bevy_fbx to bevy_mod_fbx. There is no broken links as github smoothly setups redirects, but we'd like of course, people to actually know the correct name of the crate. I'll open a PR in literally just a second

@nicopap nicopap mentioned this pull request Aug 8, 2022
Merged
@nicopap nicopap deleted the n36 branch August 8, 2022 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ozkriff ozkriff ozkriff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicopap @ozkriff