chore(deps): update secrecy 0.8.0 -> 0.10.3 #161
Merged
+18
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I diffed the actual crates.io contents via ```bash curl -L https://crates.io/api/v1/crates/secrecy/${VERSION}/download | tar -xf - ``` with `VERSION` as `0.8.0` and `0.10.3`, then diffing via git. It revealed nothing suspicious, with changes as claimed per their CHANGELOG.md. 0.10.0 had some breaking changes. `Secret<T>` is no longer a thing, instead there's `SecretBox<T>`. It turned out secrecy usage in bors is limited, and private keys are fed as PEM-encoded `String`s. For this, there's `SecretString`, which is just an alias for `SecretBox<str>`. Accepting it and converting to bytes in `create_github_client` simplifies code at the call sites a bit.
|
Thank you! :) PEM should hopefully be "just text", so UTF-8 encoding should handle it just fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I diffed the actual crates.io contents via
with
VERSIONas0.8.0and0.10.3, thendiffing via git. It revealed nothing suspicious,
with changes as claimed per their CHANGELOG.md.
0.10.0 had some breaking changes.
Secret<T>isno longer a thing, instead there's
SecretBox<T>. It turned out secrecy usage in bors is limited,and private keys are fed as PEM-encoded
Strings. For this, there'sSecretString, which is just an alias forSecretBox<str>. Accepting it andconverting to bytes in
create_github_clientsimplifies code at the call sites a bit.