Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

-Z timings: no graph for rust-analyzer build #7388

Closed
matthiaskrgr opened this issue Sep 19, 2019 · 3 comments · Fixed by #7397
Closed

-Z timings: no graph for rust-analyzer build #7388

matthiaskrgr opened this issue Sep 19, 2019 · 3 comments · Fixed by #7397
Assignees
Labels
A-timings Area: timings C-bug Category: bug

Comments

@matthiaskrgr
Copy link
Member

repo: https:/rust-analyzer/rust-analyzer

I was running
cargo clean ; RUSTC_WRAPPER="" ~/vcs/github/cargo/target/release/cargo build --release -Ztimings --all-targets
but there was no graph displayed in the html summary:

ra_timings

cargo 3596cb8
rustc 1.39.0-nightly (eb48d6bde 2019-09-12)

@matthiaskrgr matthiaskrgr added the C-bug Category: bug label Sep 19, 2019
@alexcrichton
Copy link
Member

Could you gist the html file as well? If you open the JS console are there any errors showing up there as well?

(I just build rust-analyzer and got some graphs so I wasn't able to trivially reproduce it at least)

@matthiaskrgr
Copy link
Member Author

Here's the html: https://gist.github.com/matthiaskrgr/5941caa4217343abbea4a566f644cfc6

There were some errors in the js console but I'm not sure if they were coming from the report page:

nsLoginManager: searchLogins: `formActionOrigin` or `httpRealm` is recommended 7 LoginManager.jsm:467:13
uncaught exception: Object
uncaught exception: Object
uncaught exception: Object
uncaught exception: Object
Content Security Policy: Ignoring ‘x-frame-options’ because of ‘frame-ancestors’ directive.
uncaught exception: Object 4
TypeError: Argument 1 of PrecompiledScript.executeInGlobal is not an object. ExtensionContent.jsm:554:25
TypeError: can't access dead object
uncaught exception: Object
Error: UrlbarInput: Should have a UrlbarResult since pageproxystate != 'valid' and valueIsTyped == false UrlbarInput.jsm:1056:15
Content Security Policy: Ignoring ‘x-frame-options’ because of ‘frame-ancestors’ directive.
Content Security Policy: Ignoring ‘x-frame-options’ because of ‘frame-ancestors’ directive.
Content Security Policy: Ignoring ‘x-frame-options’ because of ‘frame-ancestors’ directive.
uncaught exception: Object 

@alexcrichton
Copy link
Member

Ok looks like I'm getting a JS error, and it's just an obscure NS_ERROR_FAILURE (that's literally the whole exception message) which happens on this line.

I suspect the issue is that the canvas is requested to just be simply too big, its width is 25100 and height is 6682, and that's probably hitting some "reasonable limit" for the maximum width of a canvas or something like that.

I set the slider to as low as it could go, refreshed the page, and the graph rendered. Probably just means we need to do some more massaging with the scaling to ensure that it doesn't scale absurdly large like this.

(cc @ehuss)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-timings Area: timings C-bug Category: bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants