-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Panic in cargo doc
with resolver = "2" when indirectly depending on proc-macro2
#9064
Comments
cargo doc
with resolver = "2" when depending on proc-macro2cargo doc
with resolver = "2" when indirectly depending on proc-macro2
Error: The feature Please let |
@nerosnm Thanks for the clear report and reproduction. I see what's going on, but it is uncovering some long festering problems with how cargo integrates with rustdoc. I'll need to think about it for a bit to try to decide on the best course to take. |
Enable triagebot's relabel functionality ### What does this PR try to resolve? This fixes the following failure that rustbot currently posts whenever someone tries to use "<b>`@</b><b>rustbot</b>` label" in this repository. > **Error**: The feature `relabel` is not enabled in this repository. > To enable it add its section in the `triagebot.toml` in the root of the repository. Unauthenticated relabel has been enabled in rust-lang/rust for nearly 4 years. People overwhelmingly use it in good faith. <br> ### How should we test and review this PR? Compare against https:/rust-lang/rust/blob/1.66.0/triagebot.toml. Also skim through the 7 pages of labels on https:/rust-lang/cargo/labels, whether it makes sense the ones I decided to allow arbitrary GitHub users to apply. <br> ### Additional information Attempted uses of "<b>`@</b><b>rustbot</b>` label", that failed, but this PR would allow: - #10343 (comment) - #10243 (comment) - #9982 (comment) - #9128 (comment) - #9067 (comment) - #8441 (comment) - #11432 (comment) - #8841 (comment) - #10820 (comment) - #10572 (comment) - #9114 (comment) - #8980 (comment) - #9064 (comment) - #8726 (comment) - #8089 (comment)
Problem
cargo doc
panics when run on crate A that depends on crate B, when crate B depends onproc-macro2
. This does not happen when directly runningcargo doc
on crate B.Error & Backtrace
Steps
cargo doc
(or, more explicitly,cargo +nightly-2021-01-10 doc
)Possible Solution(s)
This looks similar to #8774 to me, although from what I can tell it's not explicitly relying on any features specific to the new resolver.
Notes
Output of
cargo version
: cargo 1.51.0-nightly (329895f 2021-01-06)The text was updated successfully, but these errors were encountered: