Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error message for an array value in the manifest #10944

Merged
merged 2 commits into from
Aug 16, 2022
Merged

Improve error message for an array value in the manifest #10944

merged 2 commits into from
Aug 16, 2022

Conversation

phankydn
Copy link
Contributor

@phankydn phankydn commented Aug 6, 2022

Fixes #10942

The error message will be:

error: failed to parse manifest at `/Users/..`

Caused by:
  invalid type: string "Ky", expected an array for key `package.authors`

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @ehuss (or someone else) soon.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 6, 2022
Rustin170506
Rustin170506 reviewed Aug 6, 2022
View reviewed changes
Copy link
Member

@Rustin170506 Rustin170506 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! We'd better add a test.

src/cargo/util/toml/mod.rs Outdated Show resolved Hide resolved
src/cargo/util/toml/mod.rs Show resolved Hide resolved
src/cargo/util/toml/mod.rs Outdated Show resolved Hide resolved
@Rustin170506
Copy link
Member

You can run cargo fmt -all to format your code. That's will make the CI pass.

@Rustin170506 Rustin170506 mentioned this pull request Aug 6, 2022
Closed
epage
epage reviewed Aug 6, 2022
View reviewed changes
src/cargo/util/toml/mod.rs Outdated Show resolved Hide resolved
@epage
Copy link
Contributor

epage commented Aug 16, 2022

@bors r+

@bors
Copy link
Collaborator

bors commented Aug 16, 2022

📌 Commit 8f1a75d has been approved by epage

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 16, 2022
@bors
Copy link
Collaborator

bors commented Aug 16, 2022

⌛ Testing commit 8f1a75d with merge 9809f8f...

@epage epage mentioned this pull request Aug 16, 2022
Closed
@bors
Copy link
Collaborator

bors commented Aug 16, 2022

☀️ Test successful - checks-actions
Approved by: epage
Pushing 9809f8f to master...

@bors bors merged commit 9809f8f into rust-lang:master Aug 16, 2022
@ehuss ehuss mentioned this pull request Aug 17, 2022
Merged
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Aug 17, 2022
@matthiaskrgr
Rollup merge of rust-lang#100656 - ehuss:update-cargo, r=ehuss
75e1e31 
Update cargo

3 commits in efd4ca3dc0b89929dc8c5f5c023d25978d76cb61..9809f8ff33c2b998919fd0432c626f0f7323697a
2022-08-12 01:28:28 +0000 to 2022-08-16 22:10:06 +0000
- Improve error message for an array value in the manifest (rust-lang/cargo#10944)
- Fix file locking being not supported on Android raising an error (rust-lang/cargo#10975)
- Bump to 0.66.0, update changelog (rust-lang/cargo#10983)
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Aug 17, 2022
@matthiaskrgr
Rollup merge of rust-lang#100656 - ehuss:update-cargo, r=ehuss
36d8d55 
Update cargo

3 commits in efd4ca3dc0b89929dc8c5f5c023d25978d76cb61..9809f8ff33c2b998919fd0432c626f0f7323697a
2022-08-12 01:28:28 +0000 to 2022-08-16 22:10:06 +0000
- Improve error message for an array value in the manifest (rust-lang/cargo#10944)
- Fix file locking being not supported on Android raising an error (rust-lang/cargo#10975)
- Bump to 0.66.0, update changelog (rust-lang/cargo#10983)
@ehuss ehuss added this to the 1.65.0 milestone Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@epage epage epage left review comments

@Muscraft Muscraft Muscraft left review comments

@Rustin170506 Rustin170506 Rustin170506 left review comments

Assignees

@ehuss ehuss

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.65.0
Development

Successfully merging this pull request may close these issues.

Improve error message displayed when a string is used instead of an array for 'authors' in the manifest
7 participants
@phankydn @rust-highfive @Rustin170506 @epage @bors @Muscraft @ehuss