Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test for issue #2064 #3396

Merged
merged 1 commit into from
Dec 14, 2016
Merged

Test for issue #2064 #3396

merged 1 commit into from
Dec 14, 2016

Conversation

kornelski
Copy link
Contributor

I've tried to reproduce the problem from #2064, but to my surprise the test passes reliably :)

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@alexcrichton
Copy link
Member

Yeah in this specific case the largest version of util satisfies all dependencies and Cargo will always choose the largest first. I think that #2064 shows up more so when there are multiple solutions that span major versions, so Cargo doesn't always select the right major version to go with a particular crate (e.g. it doesn't minimize major versions).

I'm ok adding this as a test case though if you'd like!

@kornelski
Copy link
Contributor Author

I see. I've recreated structure of packages that caused me headaches, but I didn't realize my versions were 0.x, which are "major".

Yes, please merge it.

@alexcrichton
Copy link
Member

@bors: r+

Ok, sounds good to me.

@bors
Copy link
Collaborator

bors commented Dec 13, 2016

📌 Commit 0b448a6 has been approved by alexcrichton

@bors
Copy link
Collaborator

bors commented Dec 14, 2016

⌛ Testing commit 0b448a6 with merge bd65b61...

@bors
Copy link
Collaborator

bors commented Dec 14, 2016

💔 Test failed - status-appveyor

@alexcrichton
Copy link
Member

alexcrichton commented Dec 14, 2016 via email

@bors
Copy link
Collaborator

bors commented Dec 14, 2016

⌛ Testing commit 0b448a6 with merge f1f52e1...

bors added a commit that referenced this pull request Dec 14, 2016
Test for issue #2064

I've tried to reproduce the problem from #2064, but to my surprise the test passes reliably :)
@bors
Copy link
Collaborator

bors commented Dec 14, 2016

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing f1f52e1 to master...

@bors bors merged commit 0b448a6 into rust-lang:master Dec 14, 2016
@kornelski kornelski deleted the test branch December 14, 2016 14:53
@ehuss ehuss added this to the 1.15.0 milestone Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants