Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable frozen_flag_preserves_old_lockfile test #4759

Closed
wants to merge 1 commit into from

Conversation

nrc
Copy link
Member

@nrc nrc commented Nov 28, 2017

@Mark-Simulacrum
Copy link
Member

Before we do this, I'd want some confirmation that we haven't actually somehow regressed behavior here. This test is critical to Rust today: we cannot run crater due to lockfile differences if it fails.

In general, this (IMO) is P-high to re-enable if we do disable it IMO.

@nrc
Copy link
Member Author

nrc commented Nov 29, 2017

Before we do this, I'd want some confirmation that we haven't actually somehow regressed behavior here

Whether we've regressed behaviour or not, this test is still buggy and having the buggy test present isn't preventing any behaviour regressing, it's just blocking other code landing (which would fix an important regression).

@Mark-Simulacrum
Copy link
Member

Yeah, that's true. I think we can actually mark the test as #[ignore] instead of commenting it out. Unfortunately, this can't land until rust-lang/rust#46271 is fixed AFAICT.

I guess I'm okay with landing even without confirming, but I'd prefer that we confirmed. Either way, I guess, it's a high priority thing to fix this test.

@alexcrichton
Copy link
Member

I've found the failure, will submit a fix shortly.

@alexcrichton
Copy link
Member

Ok I've opened up #4762 with what I believe is the fix. I'm gonna close this for now but if that doesn't fix it we can reopen an temporarily disable!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants