Disallow invalid dependency names through crate renaming #8090
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #6656
As suggested in the issue, I simply checked the dep names by calling
validate_package_name
on the dependencies during the TOML deserialization process.It might be a bit too strict (and sudden) to error out in this case, so it might be best to convert this into a warning instead. However, this is pretty invalid behavior so I'm not too sure really.