Allow passing a registry index url directly to cargo install

[kellda]

Fixes #8318

[rust-highfive]

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Eh2406 (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

[Eh2406]

Thank you! I'm happily surprised that the diff is so small! It definitely needs a test or three, and a review from someone that knows the intricacies.

[kellda]

Could you please tell me where to add tests (integration or unit) and if possible tell me if there are similar tests for other commands that I can look at ?

[Eh2406]

Most of the install tests are in tests\testsuite\install.rs or in tests\testsuite\install_upgrade.rs

[ehuss]

Thanks! I think instead of modifying existing tests, it would be best to add a new one. It can probably be more or less just like simple, minus the uninstall step which isn't really necessary.

[kellda]

Well I tried to do something like what's done for publish and search.
Currently no command have tests for --install on its own, so I'm not really sure what / how to test it properly.

Also I have some trouble testing locally right now, that doesn't help to write tests that passes

[ehuss]

The current errors are due to the use of {reg}. It needs the format! macro to pass in the value, similar to this.

Otherwise, I would just copy the install::simple test as a new test, and add the --index flag.

If you're having trouble running tests, feel free to post what issues you're running into, I may be able to help.

[kellda]

The current errors are due to the use of {reg}. It needs the format! macro to pass in the value.

Yes I figured it out but didn't fixed it yet.

If you're having trouble running tests

Not sure you can help, here's my issues anyway:
Last things I tryed:

• cargo build then cargo test --no-run -> error: could not compile cargo (says rustc failed because (signal: 9, SIGKILL: kill))
• rerun cargo test --no-run -> compiled fine
• cargo test -> most tests run fine, but testsuite fails: (signal: 4, SIGILL: illegal instruction)

So not really related to the test framework, I dunno if I messed up with apt-get or if it's some regression in rustc, or if something else went wrong with my linux install...

[ehuss]

Oh, that's a tough one. I would try to get a core dump or attach a debugger for the situation that causes SIGKILL. Which rustc are you using? Did you install it with rustup?

SIGILL happens when there is a panic inside a panic.

[kellda]

I use rust stable 1.44.0 via rustup

[kellda]

Ok now it works, sorry for the multiples pushes and CI runs. I'll make sure I can run tests locally before my next PR

[ehuss]

Thanks! However, as I mentioned, I think it would be ideal just to add a new test case instead of modifying the existing ones. I think one new test, based on simple, should be sufficient.

[kellda]

Is it OK now ?

[ehuss]

Looks great, thanks! I pushed a small commit to update the man page.
@bors r+

[bors]

📌 Commit a0fb62f has been approved by ehuss

[bors]

⌛ Testing commit a0fb62f with merge 56636e9...

[bors]

☀️ Test successful - checks-azure
Approved by: ehuss
Pushing 56636e9 to master...