Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reworks the LTO computation a little to address a few issues:
cargo build
in a project with both a lib and bin would not engage the optimization introduced in Don't force rustc to do codegen for LTO builds #8192 where the lib should be compiled with-C linker-plugin-lto
(bitcode only). This happened because the old code was starting root units asLto::None
. The solution here is to conditionally choose the starting Lto for roots.-C linker-plugin-lto
which is not valid.lto::between_builds
, where the second build the lib is now fresh.lib
target will now support LTO.I scattered some comments throughout, hopefully it's not too difficult to follow.
Closes #8337