Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement warning for ignored trailing arguments #9561

Merged
merged 1 commit into from
Jun 10, 2021
Merged

Implement warning for ignored trailing arguments #9561

merged 1 commit into from
Jun 10, 2021

Conversation

In-line
Copy link
Contributor

@In-line In-line commented Jun 9, 2021 •
edited
Loading

No description provided.

@rust-highfive
Copy link

r? @Eh2406

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 9, 2021
@In-line In-line force-pushed the add-warning-for-ignored-arguments branch from b6d9248 to dd79375 Compare June 9, 2021 14:44
@In-line In-line changed the title Implement warning for ignored trailing arguments in case built-in `ca… Implement warning for ignored trailing arguments Jun 9, 2021
@In-line In-line force-pushed the add-warning-for-ignored-arguments branch from dd79375 to 29eaf36 Compare June 9, 2021 14:46
@In-line
Copy link
Contributor Author

In-line commented Jun 9, 2021

r? @ehuss

@rust-highfive rust-highfive assigned ehuss and unassigned Eh2406 Jun 9, 2021
@In-line
Copy link
Contributor Author

In-line commented Jun 9, 2021

https://stackoverflow.com/questions/67903849/whats-the-different-between-cargo-build-and-cargo-build

In-line
In-line commented Jun 9, 2021
View reviewed changes
src/bin/cargo/cli.rs
(Some(_), None) => {
// Command is built-in and is not conflicting with alias, but contains ignored values.
if let Some(mut values) = args.values_of("") {
config.shell().warn(format!(
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be error?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think an error would be fine.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ehuss It can break backward compatability

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you're concerned about back compat, that's fine too. It can always be changed to an error in the future if desired.

@In-line
Implement warning for ignored trailing arguments
e5d10f9 
in case built-in `cargo` command was invoked with `--`
@In-line In-line force-pushed the add-warning-for-ignored-arguments branch from 29eaf36 to e5d10f9 Compare June 9, 2021 14:51
@Eh2406
Copy link
Contributor

Eh2406 commented Jun 9, 2021

Seams reasonable to me. Eric or Alex, should this be a warn and is this the right place for a check?

@ehuss
Copy link
Contributor

ehuss commented Jun 10, 2021

Thanks!

@bors r+

@bors
Copy link
Collaborator

bors commented Jun 10, 2021

📌 Commit e5d10f9 has been approved by ehuss

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 10, 2021
@bors
Copy link
Collaborator

bors commented Jun 10, 2021

⌛ Testing commit e5d10f9 with merge da2c770...

@bors
Copy link
Collaborator

bors commented Jun 10, 2021

☀️ Test successful - checks-actions
Approved by: ehuss
Pushing da2c770 to master...

@bors bors merged commit da2c770 into rust-lang:master Jun 10, 2021
@ehuss ehuss mentioned this pull request Jun 11, 2021
Merged
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Jun 11, 2021
@Dylan-DPC
Rollup merge of rust-lang#86207 - ehuss:update-cargo, r=ehuss
7e3fb32 
Update cargo

10 commits in aa8b09297bb3156b849e73db48af4cd050492fe6..81537ee3f7bd97ff7821b6c86c148764d40d26cd
2021-06-09 00:28:53 +0000 to 2021-06-11 00:00:14 +0000
- Change how the fix_deny_warnings_but_not_others test works (rust-lang/cargo#9571)
- Add mising documentation regarding `cargo doc` (rust-lang/cargo#9565)
- Implement warning for ignored trailing arguments (rust-lang/cargo#9561)
- Make clippy happy (rust-lang/cargo#9569)
- Fix rustc/rustdoc config values to be config-relative. (rust-lang/cargo#9566)
- Update rustfix. (rust-lang/cargo#9567)
- Warn if an "all" target is specified, but we don't match anything (rust-lang/cargo#9549)
- add default_run to SerializedPackage (rust-lang/cargo#9550)
- respect user choice of lib/bin over heuristics (rust-lang/cargo#9522)
- Add a mean to mutably access the members of a workspace (rust-lang/cargo#9547)
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Jun 11, 2021
@JohnTitor
Rollup merge of rust-lang#86207 - ehuss:update-cargo, r=ehuss
783874c 
Update cargo

10 commits in aa8b09297bb3156b849e73db48af4cd050492fe6..81537ee3f7bd97ff7821b6c86c148764d40d26cd
2021-06-09 00:28:53 +0000 to 2021-06-11 00:00:14 +0000
- Change how the fix_deny_warnings_but_not_others test works (rust-lang/cargo#9571)
- Add mising documentation regarding `cargo doc` (rust-lang/cargo#9565)
- Implement warning for ignored trailing arguments (rust-lang/cargo#9561)
- Make clippy happy (rust-lang/cargo#9569)
- Fix rustc/rustdoc config values to be config-relative. (rust-lang/cargo#9566)
- Update rustfix. (rust-lang/cargo#9567)
- Warn if an "all" target is specified, but we don't match anything (rust-lang/cargo#9549)
- add default_run to SerializedPackage (rust-lang/cargo#9550)
- respect user choice of lib/bin over heuristics (rust-lang/cargo#9522)
- Add a mean to mutably access the members of a workspace (rust-lang/cargo#9547)
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 12, 2021
@bors
Auto merge of rust-lang#86207 - ehuss:update-cargo, r=ehuss
302468e 
Update cargo

11 commits in aa8b09297bb3156b849e73db48af4cd050492fe6..44456677b5d1d82fe981c955dc5c67734b31f340
2021-06-09 00:28:53 +0000 to 2021-06-12 18:00:01 +0000
- Fix package_default_run test. (rust-lang/cargo#9577)
- Change how the fix_deny_warnings_but_not_others test works (rust-lang/cargo#9571)
- Add mising documentation regarding `cargo doc` (rust-lang/cargo#9565)
- Implement warning for ignored trailing arguments (rust-lang/cargo#9561)
- Make clippy happy (rust-lang/cargo#9569)
- Fix rustc/rustdoc config values to be config-relative. (rust-lang/cargo#9566)
- Update rustfix. (rust-lang/cargo#9567)
- Warn if an "all" target is specified, but we don't match anything (rust-lang/cargo#9549)
- add default_run to SerializedPackage (rust-lang/cargo#9550)
- respect user choice of lib/bin over heuristics (rust-lang/cargo#9522)
- Add a mean to mutably access the members of a workspace (rust-lang/cargo#9547)
@In-line In-line deleted the add-warning-for-ignored-arguments branch July 23, 2021 14:08
@ehuss ehuss added this to the 1.55.0 milestone Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehuss ehuss ehuss left review comments

Assignees

@ehuss ehuss

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.55.0
Development

Successfully merging this pull request may close these issues.
5 participants
@In-line @rust-highfive @Eh2406 @ehuss @bors