Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace vector of tuples with BTreeMap which already is sorted and free of duplicate #1177

Merged
merged 1 commit into from
Aug 11, 2024

Conversation

mati865
Copy link
Contributor

@mati865 mati865 commented Aug 10, 2024

I think this is more convenient to work with but feel free to close it if you don't agree.

Depends on: #1176

Copy link
Collaborator

@NobodyXu NobodyXu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah using BTreeMap is indeed than Vec + sort_unstable

@NobodyXu
Copy link
Collaborator

cc @mati865 would you like to rebase this?

@mati865 mati865 marked this pull request as ready for review August 11, 2024 09:01
Copy link
Collaborator

@NobodyXu NobodyXu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@NobodyXu NobodyXu merged commit eb33906 into rust-lang:main Aug 11, 2024
26 checks passed
@github-actions github-actions bot mentioned this pull request Aug 11, 2024
@mati865 mati865 deleted the btreemaps branch August 11, 2024 10:43
@github-actions github-actions bot mentioned this pull request Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants