-
Notifications
You must be signed in to change notification settings - Fork 442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Cargo's target information when possible #1225
Open
madsmtm
wants to merge
14
commits into
rust-lang:main
Choose a base branch
from
madsmtm:parse-targets
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Commits on Sep 30, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 268fb9b - Browse repository at this point
Copy the full SHA 268fb9bView commit details -
Use Cargo's target information when possible
rustc's target triples generally only have a vague resemblance to each other and to the information needed by `cc`. Let's instead prefer `CARGO_CFG_*` variables when available, since these contain the information directly from the compiler itself. In the cases where it isn't available (i.e. when running outside of a build script), we fall back to parsing the target triple, but instead of doing it in an ad-hoc fashion with string manipulation, we do it in a more structured fashion up front.
Configuration menu - View commit details
-
Copy full SHA for 0b60b02 - Browse repository at this point
Copy the full SHA 0b60b02View commit details
Commits on Oct 2, 2024
-
Configuration menu - View commit details
-
Copy full SHA for f4446b3 - Browse repository at this point
Copy the full SHA f4446b3View commit details
Commits on Oct 8, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 74c9897 - Browse repository at this point
Copy the full SHA 74c9897View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5bb25a5 - Browse repository at this point
Copy the full SHA 5bb25a5View commit details -
Configuration menu - View commit details
-
Copy full SHA for f857326 - Browse repository at this point
Copy the full SHA f857326View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5ade71f - Browse repository at this point
Copy the full SHA 5ade71fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5c7adfe - Browse repository at this point
Copy the full SHA 5c7adfeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1ce8dd6 - Browse repository at this point
Copy the full SHA 1ce8dd6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1d2bafc - Browse repository at this point
Copy the full SHA 1d2bafcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 36b3bb7 - Browse repository at this point
Copy the full SHA 36b3bb7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1117c50 - Browse repository at this point
Copy the full SHA 1117c50View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8da1265 - Browse repository at this point
Copy the full SHA 8da1265View commit details -
Configuration menu - View commit details
-
Copy full SHA for e7e5b67 - Browse repository at this point
Copy the full SHA e7e5b67View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.