Adjust "version invalid / not found" errors to reply with "404 Not Found" #7851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `semver::Version::parse()` call is only used to avoid getting a database connection from the pool when we already know that such a version can't exist in the database. In that case we don't need to reply with a special error message though, and can instead reply with the same error that we send when a version isn't found in the database.
Turbo87
added
C-enhancement ✨
JohnTitor
approved these changes
Jan 2, 2024
This was referenced Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't need to use
cargo_err()(aka. "200 OK") responses in these error cases anymore since the cargo compat middleware will ensure that we reply with a compatible status code for cargo-relevant endpoints.This PR extracts a new
version_not_found()fn and then adjusts its implementation to respond with "404 Not Found" instead.Related: