fix queue size metrics with priorities #2301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
S-waiting-on-review
syphar
force-pushed
the
fix-queue-metricvs
branch
from
38e69ff
to
f85396e
Compare
Nemo157
reviewed
Nov 8, 2023
syphar
force-pushed
the
fix-queue-metricvs
branch
2 times, most recently
from
04f06e4
to
5c0fc96
Compare
syphar
force-pushed
the
fix-queue-metricvs
branch
from
5c0fc96
to
e830625
Compare
Nemo157
approved these changes
Nov 9, 2023
github-actions
bot
added
S-waiting-on-deploy
syphar
removed
the
S-waiting-on-deploy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking at queue sizes I saw that these are "hanging" when going to zero:
When a certain priority has a queued item at any point in time, it's added to the metric. When we don't update the value any more, the last value is used. With the old logic, that would mean when the queued item count for a certain priority goes to zero after being >0, the old value is kept.
The first solution is to just reset the metric before inserting all current values. We see how this would look like in the end of the screenshot, where I did a server restart, so the metric content was reset.
What is not so nice with this is that it leads to gaps in the graph, which also makes using some of the prometheus formular harder. So for the priorities we use the most, I insert
0as value, if there is nothing queued.