Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.3.31 #2889

Merged
merged 29 commits into from
Oct 5, 2024
Merged

Release 0.3.31 #2889

merged 29 commits into from
Oct 5, 2024

Conversation

taiki-e
Copy link
Member

@taiki-e taiki-e commented Oct 5, 2024

Changes:

Backports

@taiki-e taiki-e added the futures-0.3 Issue related to the 0.3 versions of futures label Oct 5, 2024
@taiki-e taiki-e force-pushed the 0.3-next branch 4 times, most recently from 066dd6a to 2f8a153 Compare October 5, 2024 06:35
taiki-e and others added 25 commits October 5, 2024 15:37
```
error: field `0` is never read
  --> futures-executor/tests/local_pool.rs:13:16
   |
13 | struct Pending(Rc<()>);
   |        ------- ^^^^^^
   |        |
   |        field in this struct
   |
   = note: `-D dead-code` implied by `-D warnings`
   = help: to override `-D warnings` add `#[allow(dead_code)]`
help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field
   |
13 | struct Pending(());
   |                ~~
```
```
error: the item `Box` is imported redundantly
  --> futures-core/src/future.rs:89:9
   |
89 |     use alloc::boxed::Box;
   |         ^^^^^^^^^^^^^^^^^
  --> /rustc/381d69953bb7c3390cec0fee200f24529cb6320f/library/std/src/prelude/mod.rs:115:13
   |
   = note: the item `Box` is already defined here
   |
   = note: `-D unused-imports` implied by `-D warnings`
   = help: to override `-D warnings` add `#[allow(unused_imports)]`

error: the item `Box` is imported redundantly
   --> futures-core/src/stream.rs:203:9
    |
203 |     use alloc::boxed::Box;
    |         ^^^^^^^^^^^^^^^^^
   --> /rustc/381d69953bb7c3390cec0fee200f24529cb6320f/library/std/src/prelude/mod.rs:115:13
    |
    = note: the item `Box` is already defined here
```
```
warning: trait `AssertSync` is never used
   --> futures-core/src/task/__internal/atomic_waker.rs:209:15
    |
209 |         trait AssertSync: Sync {}
    |               ^^^^^^^^^^
    |
    = note: `#[warn(dead_code)]` on by default

warning: trait `AssertKinds` is never used
   --> futures-channel/src/mpsc/mod.rs:130:7
    |
130 | trait AssertKinds: Send + Sync + Clone {}
    |       ^^^^^^^^^^^
    |
    = note: `#[warn(dead_code)]` on by default

warning: trait `AssertSendSync` is never used
  --> futures-executor/src/thread_pool.rs:48:7
   |
48 | trait AssertSendSync: Send + Sync {}
   |       ^^^^^^^^^^^^^^
   |
   = note: `#[warn(dead_code)]` on by default

warning: trait `AssertSend` is never used
  --> futures-channel/tests/mpsc.rs:13:7
   |
13 | trait AssertSend: Send {}
   |       ^^^^^^^^^^
   |
   = note: `#[warn(dead_code)]` on by default
```
```
error: redundant explicit link target
   --> futures-executor/src/local_pool.rs:314:25
    |
314 | /// Use a [`LocalPool`](LocalPool) if you need finer-grained control over
    |            -----------  ^^^^^^^^^ explicit target is redundant
    |            |
    |            because label contains path that resolves to same destination
    |
    = note: when a link's destination is not specified,
            the label is used to resolve intra-doc links
    = note: `-D rustdoc::redundant-explicit-links` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(rustdoc::redundant_explicit_links)]`
help: remove explicit link target
    |
314 | /// Use a [`LocalPool`] if you need finer-grained control over
    |           ~~~~~~~~~~~~~

error: redundant explicit link target
  --> futures-executor/src/local_pool.rs:37:33
   |
37 | /// A handle to a [`LocalPool`](LocalPool) that implements
   |                    -----------  ^^^^^^^^^ explicit target is redundant
   |                    |
   |                    because label contains path that resolves to same destination
   |
   = note: when a link's destination is not specified,
           the label is used to resolve intra-doc links
help: remove explicit link target
   |
37 | /// A handle to a [`LocalPool`] that implements
   |                   ~~~~~~~~~~~~~
```
They use pin_mut via futures-util.
* Fix unexpected `cfg` condition name: ... warnings introduced in Rust 1.80

See https://blog.rust-lang.org/2024/05/06/check-cfg.html

* io_slice_advance feature is now stable

* clippy: enable missing_const_for_thread_local lint, now checks for MSRV (see rust-lang/rust-clippy#12404)

* clippy: fixes for "doc list item without indentation" lint

* clippy: ignore incorrect "first doc comment paragraph is too long" warning

see rust-lang/rust-clippy#13315

* clippy: allow long first paragraphs in select... fn doc comments

* use workspace level setting to ignore error about the futures_sanitizer unexpected config
#2884)

Fixes the following issues in `AsyncBufRead::read_line`:
* When the future is dropped the previous string contents are not restored so the string is empty.
* If invalid UTF-8 is encountered the previous string contents are not restored.
* If an IO error occurs after `read_until_internal` already read a couple of bytes a debug assertion fails.
* Performance: The whole string to which read contents are appended is check for UTF-8 validity instead of just the added bytes.

Fixes the following issues in `AsyncBufRead::read_line`:
* If an IO error occurs after `read_until_internal` already read a couple of bytes a debug assertion fails. (#2862)

Fixes #2862
Imberflur and others added 3 commits October 5, 2024 15:38
    error: calling `set_len()` immediately after reserving a buffer creates uninitialized values
      --> futures-util/src/io/buf_reader.rs:52:13
       |
    52 |             let mut buffer = Vec::with_capacity(capacity);
       |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    53 |             buffer.set_len(capacity);
       |             ^^^^^^^^^^^^^^^^^^^^^^^^
       |
       = note: `#[deny(clippy::uninit_vec)]` on by default
       = help: initialize the buffer or wrap the content in `MaybeUninit`
       = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninit_vec
@taiki-e taiki-e force-pushed the 0.3-next branch 2 times, most recently from 757f720 to 268e73e Compare October 5, 2024 06:44
@taiki-e taiki-e merged commit 1e05281 into 0.3 Oct 5, 2024
23 checks passed
@taiki-e taiki-e deleted the 0.3-next branch October 5, 2024 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
futures-0.3 Issue related to the 0.3 versions of futures
Projects
None yet
Development

Successfully merging this pull request may close these issues.