Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

preadv2 is not supported on musl libc #3760

Closed
NobodyXu opened this issue Jun 28, 2024 · 2 comments
Closed

preadv2 is not supported on musl libc #3760

NobodyXu opened this issue Jun 28, 2024 · 2 comments
Labels
C-API-request Category: API request

Comments

@NobodyXu
Copy link

The preadv2 function is present on -gnu target, however when compiling on -musl target, which is surprising.

The jobserver-rs would like to use it to optimize it's performance rust-lang/jobserver-rs#90 (the try_acquire optimization has shipped once but reverted, so I opened another PR to use raw syscall directly).

FYI, my motivation is to that this API is used in cc-rs to improve performance.
@NobodyXu NobodyXu added the C-API-request Category: API request label Jun 28, 2024
@NobodyXu NobodyXu mentioned this issue Jun 28, 2024
Open
devnexen pushed a commit to devnexen/libc that referenced this issue Jun 28, 2024
adding preadv2/pwritev2 to linux musl (1.2.5 min.)
499ed57 
close rust-lang#3760
@faptc
Copy link

faptc commented Jul 4, 2024

closed by #3762

@NobodyXu NobodyXu closed this as completed Jul 4, 2024
@NobodyXu
Copy link
Author

NobodyXu commented Jul 4, 2024

Thank you!

nyurik pushed a commit to nyurik/libc that referenced this issue Jul 26, 2024
@nyurik
adding preadv2/pwritev2 to linux musl (1.2.5 min.)
a3c0d33 
close rust-lang#3760
tgross35 pushed a commit to tgross35/rust-libc that referenced this issue Aug 29, 2024
@tgross35
adding preadv2/pwritev2 to linux musl (1.2.5 min.)
889ad48 
close rust-lang#3760

(apply <rust-lang#3762> to `main`)
[ resolve conflicts - Trevor ]
(cherry picked from commit 499ed57)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-API-request Category: API request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@NobodyXu @faptc