utmpx api for linux musl + musl few build fixes. #3213
Conversation
|
r? @JohnTitor (rustbot has picked a reviewer for you, use r? to override) |
devnexen
force-pushed
the
utmpx_linux_musl
branch
from
a34846f
to
463286a
Compare
|
What does s-blocked mean in this context? Is there an issue with the code? |
|
Why is this trying to change O_LARGEFILE? |
|
I just looked at an alpine instance, O_LARGEFILE on x86_64 arch is the same as android so |
devnexen
force-pushed
the
utmpx_linux_musl
branch
from
463286a
to
e14037e
Compare
devnexen
force-pushed
the
utmpx_linux_musl
branch
2 times, most recently
from
922b9b1
to
e0bd2df
Compare
|
When can this PR be merged? Is it blocked waiting for a future release? |
|
@devnexen do you know what is blocking the merge of this PR? |
|
@joshtriplett did I answer your question ? |
|
@JohnTitor can this be merged? What does the tag "breakage-candidate" mean? |
|
John sent me this email explaining why this pull-request cannot be merged at the moment:
|
|
Turned out that the Cargo feature way I mentioned above isn't pragmatic, and we have to make libc 0.3 real. See #3488 (comment) for more details. |
| pub fn getutxent() -> *mut utmpx; | ||
| pub fn getutxid(ut: *const utmpx) -> *mut utmpx; | ||
| pub fn getutxline(ut: *const utmpx) -> *mut utmpx; | ||
| pub fn pututxline(ut: *const utmpx) -> *mut utmpx; | ||
| pub fn setutxent(); | ||
| pub fn endutxent(); |
There was a problem hiding this comment.
For now, we can merge non-breaking changes like this.
devnexen
force-pushed
the
utmpx_linux_musl
branch
from
e0bd2df
to
e3caaf6
Compare
|
@bors r+ |
|
☀️ Test successful - checks-actions, checks-cirrus-freebsd-13, checks-cirrus-freebsd-14 |
close #3190